From 9c893fba9e30e645873cafbe435f4e76b79a0149 Mon Sep 17 00:00:00 2001 From: Elias Projahn Date: Thu, 13 Mar 2025 18:44:01 +0100 Subject: [PATCH] Display backtraces for logged errors --- src/album_page.rs | 2 +- src/editor/tracks.rs | 2 +- src/library.rs | 4 ++-- src/library_manager.rs | 10 +++++----- src/player.rs | 8 ++++---- src/recording_tile.rs | 2 +- src/welcome_page.rs | 2 +- src/window.rs | 2 +- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/album_page.rs b/src/album_page.rs index 42bbee8..7fb5712 100644 --- a/src/album_page.rs +++ b/src/album_page.rs @@ -78,7 +78,7 @@ mod imp { .collect::>(); if let Err(err) = obj.player().append(playlist) { - log::warn!("Failed to add album to the playlits: {err}"); + log::warn!("Failed to add album to the playlits: {err:?}"); }; }) .build(); diff --git a/src/editor/tracks.rs b/src/editor/tracks.rs index 7390a2c..84d5ece 100644 --- a/src/editor/tracks.rs +++ b/src/editor/tracks.rs @@ -170,7 +170,7 @@ impl TracksEditor { match dialog.open_multiple_future(Some(window)).await { Err(err) => { if !err.matches(gtk::DialogError::Dismissed) { - log::error!("File selection failed: {err}"); + log::error!("File selection failed: {err:?}"); } } Ok(files) => { diff --git a/src/library.rs b/src/library.rs index b40ab29..c7194dd 100644 --- a/src/library.rs +++ b/src/library.rs @@ -101,7 +101,7 @@ impl Library { this_connection, &sender, ))) { - log::error!("Failed to send library action result: {err}"); + log::error!("Failed to send library action result: {err:?}"); } }); @@ -128,7 +128,7 @@ impl Library { tracks, &sender, ))) { - log::error!("Failed to send library action result: {err}"); + log::error!("Failed to send library action result: {err:?}"); } }); diff --git a/src/library_manager.rs b/src/library_manager.rs index 9171399..44fde6a 100644 --- a/src/library_manager.rs +++ b/src/library_manager.rs @@ -96,7 +96,7 @@ impl LibraryManager { match dialog.select_folder_future(Some(window)).await { Err(err) => { if !err.matches(gtk::DialogError::Dismissed) { - log::error!("Folder selection failed: {err}"); + log::error!("Folder selection failed: {err:?}"); } } Ok(folder) => window.set_library_folder(&folder), @@ -120,7 +120,7 @@ impl LibraryManager { match dialog.open_future(Some(window)).await { Err(err) => { if !err.matches(gtk::DialogError::Dismissed) { - log::error!("File selection failed: {err}"); + log::error!("File selection failed: {err:?}"); } } Ok(path) => { @@ -154,7 +154,7 @@ impl LibraryManager { self.add_process(&process); } - Err(err) => log::error!("Failed to import library: {err}"), + Err(err) => log::error!("Failed to import library: {err:?}"), } } } @@ -178,7 +178,7 @@ impl LibraryManager { match dialog.save_future(Some(window)).await { Err(err) => { if !err.matches(gtk::DialogError::Dismissed) { - log::error!("File selection failed: {err}"); + log::error!("File selection failed: {err:?}"); } } Ok(path) => { @@ -204,7 +204,7 @@ impl LibraryManager { self.add_process(&process); } - Err(err) => log::error!("Failed to export library: {err}"), + Err(err) => log::error!("Failed to export library: {err:?}"), } } } diff --git a/src/player.rs b/src/player.rs index 46993c0..2a183c2 100644 --- a/src/player.rs +++ b/src/player.rs @@ -63,7 +63,7 @@ mod imp { self.obj().pause(); } Err(err) => { - log::warn!("Failed to play from program: {err}"); + log::warn!("Failed to play from program: {err:?}"); } } } @@ -317,7 +317,7 @@ impl Player { self.play(); } Err(err) => { - log::warn!("Failed to append and play items: {err}"); + log::warn!("Failed to append and play items: {err:?}"); } } } @@ -332,7 +332,7 @@ impl Player { self.play(); } Err(err) => { - log::warn!("Failed to play from program: {err}"); + log::warn!("Failed to play from program: {err:?}"); } } } @@ -403,7 +403,7 @@ impl Player { } else if let Some(program) = self.program() { match self.generate_items(&program) { Ok(index) => self.set_current_index(index), - Err(err) => log::warn!("Failed to continue playing from program: {err}"), + Err(err) => log::warn!("Failed to continue playing from program: {err:?}"), } } } diff --git a/src/recording_tile.rs b/src/recording_tile.rs index be0644a..873f707 100644 --- a/src/recording_tile.rs +++ b/src/recording_tile.rs @@ -52,7 +52,7 @@ mod imp { let player = obj.imp().player.get().unwrap(); let playlist = player.recording_to_playlist(obj.imp().recording.get().unwrap()); if let Err(err) = player.append(playlist) { - log::error!("Failed to add recording to playlist: {err}"); + log::error!("Failed to add recording to playlist: {err:?}"); } }) .build(); diff --git a/src/welcome_page.rs b/src/welcome_page.rs index 9e4e38a..d64fe13 100644 --- a/src/welcome_page.rs +++ b/src/welcome_page.rs @@ -80,7 +80,7 @@ impl WelcomePage { { Err(err) => { if !err.matches(gtk::DialogError::Dismissed) { - log::error!("Folder selection failed: {err}"); + log::error!("Folder selection failed: {err:?}"); } } Ok(folder) => { diff --git a/src/window.rs b/src/window.rs index 7e6433c..2205af3 100644 --- a/src/window.rs +++ b/src/window.rs @@ -172,7 +172,7 @@ mod imp { glib::signal::Propagation::Stop } else { if let Err(err) = self.obj().save_window_state() { - log::warn!("Failed to save window state: {err}"); + log::warn!("Failed to save window state: {err:?}"); } glib::signal::Propagation::Proceed