Implement some Clippy suggestions

src/album_page.rs

@@ -72,8 +72,7 @@ mod imp {
                         .unwrap()
                         .recordings
                         .iter()
-                        .map(|r| obj.player().recording_to_playlist(r))
+                        .flat_map(|r| obj.player().recording_to_playlist(r))
-                        .flatten()
                         .collect::<Vec<PlaylistItem>>();
 
                     if let Err(err) = obj.player().append(playlist) {
@@ -165,8 +164,7 @@ impl AlbumPage {
             .unwrap()
             .recordings
             .iter()
-            .map(|r| self.player().recording_to_playlist(r))
+            .flat_map(|r| self.player().recording_to_playlist(r))
-            .flatten()
             .collect::<Vec<PlaylistItem>>();
 
         self.player().append_and_play(playlist);

src/album_tile.rs

@@ -45,7 +45,7 @@ impl AlbumTile {
     pub fn new(album: &Album) -> Self {
         let obj: Self = glib::Object::new();
 
-        obj.imp().title_label.set_label(&album.name.get());
+        obj.imp().title_label.set_label(album.name.get());
         obj.imp().album.set(album.clone()).unwrap();
 
         obj

src/editor/program.rs

@@ -69,7 +69,7 @@ mod imp {
             self.parent_constructed();
 
             let set_design_action = gio::ActionEntry::builder("set-design")
-                .parameter_type(Some(&glib::VariantTy::STRING))
+                .parameter_type(Some(glib::VariantTy::STRING))
                 .state(glib::Variant::from("program-1"))
                 .build();
 

src/editor/recording.rs

@@ -246,7 +246,7 @@ impl RecordingEditor {
     }
 
     fn set_work(&self, work: Work) {
-        self.imp().work_row.set_title(&work.name.get());
+        self.imp().work_row.set_title(work.name.get());
         self.imp().work_row.set_subtitle(
             &work
                 .composers_string()

src/editor/tracks.rs

@@ -245,8 +245,7 @@ impl TracksEditor {
                     .track_rows
                     .borrow()
                     .iter()
-                    .map(|t| t.track_data().parts.clone())
+                    .flat_map(|t| t.track_data().parts.clone())
-                    .flatten()
                     .collect::<Vec<Work>>()
             };
 

src/editor/work.rs

@@ -390,17 +390,15 @@ impl WorkEditor {
             };
 
             self.emit_by_name::<()>("created", &[&part]);
+        } else if let Some(work_id) = self.imp().work_id.get() {
+            library
+                .update_work(work_id, name, parts, composers, instruments, enable_updates)
+                .unwrap();
         } else {
-            if let Some(work_id) = self.imp().work_id.get() {
+            let work = library
-                library
+                .create_work(name, parts, composers, instruments, enable_updates)
-                    .update_work(work_id, name, parts, composers, instruments, enable_updates)
+                .unwrap();
-                    .unwrap();
+            self.emit_by_name::<()>("created", &[&work]);
-            } else {
-                let work = library
-                    .create_work(name, parts, composers, instruments, enable_updates)
-                    .unwrap();
-                self.emit_by_name::<()>("created", &[&work]);
-            }
         }
 
         self.imp().navigation.get().unwrap().pop();

src/editor/work/part_row.rs

@@ -145,7 +145,7 @@ impl WorkEditorPartRow {
     }
 
     fn set_part(&self, part: Work) {
-        self.set_title(&part.name.get());
+        self.set_title(part.name.get());
 
         if !part.parts.is_empty() {
             self.set_subtitle(

src/empty_page.rs

@@ -92,8 +92,8 @@ impl EmptyPage {
     #[template_callback]
     async fn download_library(&self) {
         let dialog = adw::AlertDialog::builder()
-            .heading(&gettext("Disclaimer"))
+            .heading(gettext("Disclaimer"))
-            .body(&gettext("You are about to download a library of audio files. These are from recordings that are in the public domain under EU law and are hosted on a server within the EU. Please ensure that you comply with the copyright laws of you country."))
+            .body(gettext("You are about to download a library of audio files. These are from recordings that are in the public domain under EU law and are hosted on a server within the EU. Please ensure that you comply with the copyright laws of you country."))
             .build();
 
         dialog.add_response("continue", &gettext("Continue"));

src/library/edit.rs

@@ -209,7 +209,7 @@ impl Library {
     ) -> Result<Work> {
         let connection = &mut *self.imp().connection.get().unwrap().lock().unwrap();
 
-        let work = self.create_work_priv(
+        let work = Self::create_work_priv(
             connection,
             name,
             parts,
@@ -226,7 +226,6 @@ impl Library {
     }
 
     fn create_work_priv(
-        &self,
         connection: &mut SqliteConnection,
         name: TranslatedString,
         parts: Vec<Work>,
@@ -242,7 +241,7 @@ impl Library {
         let work_data = tables::Work {
             work_id: work_id.clone(),
             parent_work_id: parent_work_id.map(|w| w.to_string()),
-            sequence_number: sequence_number,
+            sequence_number,
             name,
             created_at: now,
             edited_at: now,
@@ -256,7 +255,7 @@ impl Library {
             .execute(connection)?;
 
         for (index, part) in parts.into_iter().enumerate() {
-            self.create_work_priv(
+            Self::create_work_priv(
                 connection,
                 part.name,
                 part.parts,
@@ -309,7 +308,7 @@ impl Library {
     ) -> Result<()> {
         let connection = &mut *self.imp().connection.get().unwrap().lock().unwrap();
 
-        self.update_work_priv(
+        Self::update_work_priv(
             connection,
             work_id,
             name,
@@ -327,7 +326,6 @@ impl Library {
     }
 
     fn update_work_priv(
-        &self,
         connection: &mut SqliteConnection,
         work_id: &str,
         name: TranslatedString,
@@ -367,7 +365,7 @@ impl Library {
                 .optional()?
                 .is_some()
             {
-                self.update_work_priv(
+                Self::update_work_priv(
                     connection,
                     &part.work_id,
                     part.name,
@@ -381,7 +379,7 @@ impl Library {
             } else {
                 // Note: The previously used ID is discarded. This should be OK, because
                 // at this point, the part ID should not have been used anywhere.
-                self.create_work_priv(
+                Self::create_work_priv(
                     connection,
                     part.name,
                     part.parts,

src/library/exchange.rs

@@ -229,22 +229,18 @@ fn import_metadata_from_url_priv(
         formatx!(gettext("Downloading {}"), &url).unwrap(),
     ));
 
-    match runtime.block_on(download_tmp_file(&url, &sender)) {
+    match runtime.block_on(download_tmp_file(&url, sender)) {
         Ok(db_file) => {
             let _ = sender.send_blocking(ProcessMsg::Message(
                 formatx!(gettext("Importing downloaded library"), &url).unwrap(),
             ));
 
             let _ = sender.send_blocking(ProcessMsg::Result(
-                import_metadata_from_file(db_file.path(), this_connection, true).and_then(
+                import_metadata_from_file(db_file.path(), this_connection, true).map(|tracks| {
-                    |tracks| {
+                    if !tracks.is_empty() {
-                        if !tracks.is_empty() {
+                        log::warn!("The metadata file at {url} contains tracks.");
-                            log::warn!("The metadata file at {url} contains tracks.");
+                    }
-                        }
+                }),
-
-                        Ok(())
-                    },
-                ),
             ));
         }
         Err(err) => {
@@ -269,7 +265,7 @@ fn import_library_from_url_priv(
         formatx!(gettext("Downloading {}"), &url).unwrap(),
     ));
 
-    let archive_file = runtime.block_on(download_tmp_file(&url, &sender));
+    let archive_file = runtime.block_on(download_tmp_file(&url, sender));
 
     match archive_file {
         Ok(archive_file) => {
@@ -281,7 +277,7 @@ fn import_library_from_url_priv(
                 archive_file.path(),
                 library_folder,
                 this_connection,
-                &sender,
+                sender,
             )));
         }
         Err(err) => {

src/library/query.rs

@@ -414,7 +414,6 @@ impl Library {
                     works,
                     recordings,
                     albums,
-                    ..Default::default()
                 }
             }
             LibraryQuery {

src/main.rs

@@ -46,7 +46,7 @@ fn main() -> glib::ExitCode {
     gettextrs::textdomain(config::PKGNAME).unwrap();
 
     gio::resources_register(
-        &gio::Resource::load(&format!(
+        &gio::Resource::load(format!(
             "{}/{}/{}.gresource",
             config::DATADIR,
             config::PKGNAME,

src/player.rs

@@ -221,14 +221,14 @@ impl Player {
             items.push(PlaylistItem::new(
                 true,
                 recording.work.composers_string(),
-                &recording.work.name.get(),
+                recording.work.name.get(),
                 Some(&performances),
                 None,
-                &self.library_path_to_file_path(&tracks[0].path),
+                self.library_path_to_file_path(&tracks[0].path),
                 &tracks[0].track_id,
             ));
         } else {
-            let mut tracks = tracks.into_iter();
+            let mut tracks = tracks.iter();
             let first_track = tracks.next().unwrap();
 
             let track_title = |track: &Track, number: usize| -> String {
@@ -249,10 +249,10 @@ impl Player {
             items.push(PlaylistItem::new(
                 true,
                 recording.work.composers_string(),
-                &recording.work.name.get(),
+                recording.work.name.get(),
                 Some(&performances),
-                Some(&track_title(&first_track, 1)),
+                Some(&track_title(first_track, 1)),
-                &self.library_path_to_file_path(&first_track.path),
+                self.library_path_to_file_path(&first_track.path),
                 &first_track.track_id,
             ));
 
@@ -260,11 +260,11 @@ impl Player {
                 items.push(PlaylistItem::new(
                     false,
                     recording.work.composers_string(),
-                    &recording.work.name.get(),
+                    recording.work.name.get(),
                     Some(&performances),
                     // track number = track index + 1 (first track) + 1 (zero based)
-                    Some(&track_title(&track, index + 2)),
+                    Some(&track_title(track, index + 2)),
-                    &self.library_path_to_file_path(&track.path),
+                    self.library_path_to_file_path(&track.path),
                     &track.track_id,
                 ));
             }

src/program.rs

@@ -83,7 +83,7 @@ impl Program {
     }
 
     pub fn from_query(query: LibraryQuery) -> Self {
-        let settings = gio::Settings::new(&config::APP_ID);
+        let settings = gio::Settings::new(config::APP_ID);
 
         glib::Object::builder()
             .property(

src/program_tile.rs

@@ -56,7 +56,7 @@ mod imp {
             self.set_program_from_settings(&settings);
 
             let obj = self.obj().to_owned();
-            settings.connect_changed(Some(&self.key.get().unwrap()), move |settings, _| {
+            settings.connect_changed(Some(self.key.get().unwrap()), move |settings, _| {
                 obj.imp().set_program_from_settings(settings);
             });
         }

src/recording_tile.rs

@@ -69,7 +69,7 @@ mod imp {
                         .push(&RecordingEditor::new(
                             obj.imp().navigation.get().unwrap(),
                             obj.imp().library.get().unwrap(),
-                            Some(&obj.imp().recording.get().unwrap()),
+                            Some(obj.imp().recording.get().unwrap()),
                         ));
                 })
                 .build();
@@ -90,8 +90,8 @@ mod imp {
             let delete_action = gio::ActionEntry::builder("delete")
                 .activate(move |_, _, _| {
                     let dialog = adw::AlertDialog::builder()
-                        .heading(&gettext("Delete recording?"))
+                        .heading(gettext("Delete recording?"))
-                        .body(&gettext("The recording will be removed from your music library and the corresponding audio files will be deleted. This action cannot be undone."))
+                        .body(gettext("The recording will be removed from your music library and the corresponding audio files will be deleted. This action cannot be undone."))
                         .build();
 
                     dialog.add_response("delete", &gettext("Delete"));
@@ -142,7 +142,7 @@ impl RecordingTile {
         let obj: Self = glib::Object::new();
         let imp = obj.imp();
 
-        imp.work_label.set_label(&recording.work.name.get());
+        imp.work_label.set_label(recording.work.name.get());
         imp.composer_label.set_label(
             &recording
                 .work

src/search_page.rs

@@ -391,7 +391,7 @@ impl SearchPage {
         imp.header_box.set_visible(!query.is_empty());
 
         let highlight = if let Some(work) = &query.work {
-            imp.title_label.set_text(&work.name.get());
+            imp.title_label.set_text(work.name.get());
             if let Some(composers) = work.composers_string() {
                 imp.subtitle_label.set_text(&composers);
                 imp.subtitle_label.set_visible(true);
@@ -400,15 +400,15 @@ impl SearchPage {
             }
             Some(Tag::Work(work.to_owned()))
         } else if let Some(person) = &query.composer {
-            imp.title_label.set_text(&person.name.get());
+            imp.title_label.set_text(person.name.get());
             imp.subtitle_label.set_visible(false);
             Some(Tag::Composer(person.to_owned()))
         } else if let Some(person) = &query.performer {
-            imp.title_label.set_text(&person.name.get());
+            imp.title_label.set_text(person.name.get());
             imp.subtitle_label.set_visible(false);
             Some(Tag::Performer(person.to_owned()))
         } else if let Some(ensemble) = &query.ensemble {
-            imp.title_label.set_text(&ensemble.name.get());
+            imp.title_label.set_text(ensemble.name.get());
             imp.subtitle_label.set_visible(false);
             Some(Tag::Ensemble(ensemble.to_owned()))
         } else if let Some(instrument) = &query.instrument {

src/selector/recording.rs

@@ -294,7 +294,7 @@ impl RecordingSelectorPopover {
                     .build(),
             );
 
-            row.set_tooltip_text(Some(&work.name.get()));
+            row.set_tooltip_text(Some(work.name.get()));
 
             let work = work.clone();
             let obj = self.clone();

src/selector/work.rs

@@ -256,7 +256,7 @@ impl WorkSelectorPopover {
                     .build(),
             );
 
-            row.set_tooltip_text(Some(&work.name.get()));
+            row.set_tooltip_text(Some(work.name.get()));
 
             let work = work.clone();
             let obj = self.clone();

src/util.rs

@@ -28,7 +28,7 @@ pub fn error_toast(msgid: &str, err: anyhow::Error, toast_overlay: &adw::ToastOv
     log::error!("{msgid}: {err:?}");
 
     let toast = adw::Toast::builder()
-        .title(&gettext(msgid))
+        .title(gettext(msgid))
         .button_label("Details")
         .build();
 

src/util/error_dialog.rs

@@ -61,7 +61,7 @@ glib::wrapper! {
 impl ErrorDialog {
     pub fn present(err: &anyhow::Error, parent: &impl IsA<gtk::Widget>) {
         let obj: Self = glib::Object::builder()
-            .property("error-text", &format!("{err:?}"))
+            .property("error-text", format!("{err:?}"))
             .build();
 
         obj.present(Some(parent));

src/window.rs

@@ -202,8 +202,8 @@ mod imp {
         fn close_request(&self) -> glib::signal::Propagation {
             if self.process_manager.any_ongoing() {
                 let dialog = adw::AlertDialog::builder()
-                    .heading(&gettext("Close window?"))
+                    .heading(gettext("Close window?"))
-                    .body(&gettext(
+                    .body(gettext(
                         "There are ongoing processes that will be canceled.",
                     ))
                     .build();